- Fix tab order bug by removing switchTab call in notifyStackItemAdd. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start calling switchTab in resetCurrentTab function in order to notify stackState. This is needed because clearAllFragments pops tabIndex in tab index stack when fragment stack for that tab is empty. - Set stack count in initializeStackState method in order to create empty fragment stacks at initialization. Previous to this in order to create fragment stacks we were using root fragment provider and calling addStackItem method for each root fragments. - Start initializing root fragments when it is needed, ie. switchTab.
bilgehankalkan
approved these changes
Apr 21, 2020
erkutaras
approved these changes
Apr 21, 2020
selimtoksal
approved these changes
Apr 21, 2020
kadiraltinok
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: