Expose kafka producer, closes #9 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdulsametileri
commented
Dec 30, 2022
| "github.com/Trendyol/kafka-cronsumer/pkg/logger" | ||
| "github.com/segmentio/kafka-go/protocol" |
There was a problem hiding this comment.
We want to get rid of this dependency at our pkg/kafka directory so we defined new type alias and do some implementation FromHeaders, ToHeaders as shown above.
Abdulsametileri
commented
Dec 30, 2022
| Time time.Time | ||
| } | ||
|
|
||
| type MessageBuilder struct { |
There was a problem hiding this comment.
After implementing builder pattern in our Message struct, we wanted to extract it new file as cronsumer_message. Why we added prefix cronsumer_? It because we want to separate from internal/message struct.
Abdulsametileri
commented
Dec 30, 2022
| @@ -0,0 +1,70 @@ | |||
| package internal | |||
There was a problem hiding this comment.
We wanted to extract all header related logic to a dedicated file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.