feat: Added share link option to gurubu planner #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aegean09
requested review from
armagandalkiran,
aahmetcakir and
mertcanaltin
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Aegean09
force-pushed
the
gurubu-planner-sharelink
branch
from
15cc706 to
10c401b
Compare
mertcanaltin
requested changes
Apr 8, 2025
Comment on lines
49
to
81
| useEffect(() => { | ||
| const fetchDataFromUrl = async () => { | ||
| const teamFromUrl = searchParams.get('team'); | ||
| const boardFromUrl = searchParams.get('board'); | ||
| const boardSearchFromUrl = searchParams.get('boardSearch'); | ||
|
|
||
| if (teamFromUrl) { | ||
| const response = await pService.getOrganizationDetails(teamFromUrl); | ||
| if (response.isSuccess && response.data) { | ||
| setAssignees(response.data); | ||
| localStorage.setItem('JIRA_DEFAULT_ASSIGNEES', JSON.stringify(response.data)); | ||
| } | ||
| } | ||
|
|
||
| if (boardSearchFromUrl) { | ||
| await fetchBoards(boardSearchFromUrl); | ||
| } | ||
|
|
||
| if (boardFromUrl) { | ||
| try { | ||
| const response = await fetch(`${process.env.NEXT_PUBLIC_API_URL}/jira/${boardFromUrl}/future`); | ||
| const data: SprintResponse = await response.json(); | ||
| setSprints(data.values); | ||
| localStorage.setItem('JIRA_BOARD', boardFromUrl); | ||
| handleRefresh(); | ||
| } catch (error) { | ||
| console.error('Error fetching future sprints:', error); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| fetchDataFromUrl(); | ||
| }, [searchParams]); |
There was a problem hiding this comment.
Is searchParams constantly updated, for example, I wonder if this place will be hit every time I press a character.
Comment on lines
83
to
110
| useEffect(() => { | ||
| const teamFromUrl = searchParams.get('team'); | ||
| const boardFromUrl = searchParams.get('board'); | ||
|
|
||
| if (teamFromUrl) setSelectedTeam(teamFromUrl); | ||
| if (boardFromUrl) setSelectedBoard(boardFromUrl); | ||
| }, [searchParams]); | ||
|
|
||
| useEffect(() => { | ||
| const fetchDataFromUrl = async () => { | ||
| const teamFromUrl = searchParams.get('team'); | ||
| const boardFromUrl = searchParams.get('board'); | ||
| const boardSearchFromUrl = searchParams.get('boardSearch'); | ||
|
|
||
| if (teamFromUrl) { | ||
| const response = await pService.getOrganizationDetails(teamFromUrl); | ||
| if (response.isSuccess && response.data) { | ||
| setAssignees(response.data); | ||
| localStorage.setItem('JIRA_DEFAULT_ASSIGNEES', JSON.stringify(response.data)); | ||
| } | ||
| } | ||
|
|
||
| if (boardSearchFromUrl) { | ||
| await fetchBoards(boardSearchFromUrl); | ||
| } | ||
|
|
||
| if (boardFromUrl) { | ||
| try { | ||
| const response = await fetch(`${process.env.NEXT_PUBLIC_API_URL}/jira/${boardFromUrl}/future`); | ||
| const data: SprintResponse = await response.json(); | ||
| setSprints(data.values); | ||
| localStorage.setItem('JIRA_BOARD', boardFromUrl); | ||
| handleRefresh(); | ||
| } catch (error) { | ||
| console.error('Error fetching future sprints:', error); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| fetchDataFromUrl(); | ||
| }, [searchParams]); |
There was a problem hiding this comment.
This is very similar to the code above
mertcanaltin
reviewed
Apr 8, 2025
mertcanaltin
reviewed
Apr 8, 2025
|
please enter pr details @Aegean09 🚀 , may be too short |
|
@mertcanaltin this pr is not ready for review mate, I'm trying to solve conflicts with the previous merged pr (enes') |
mertcanaltin
changed the title
|
I got it, mate, I marked your pr as WIP (it means you working on it) |
Aegean09
force-pushed
the
gurubu-planner-sharelink
branch
from
2d27200 to
9610b8b
Compare
Aegean09
changed the title
|
@mertcanaltin i'm going to merge this, is your comments resolved? |
|
if you don't have any problems we can unite, my question is not too critical @armagandalkiran |
armagandalkiran
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gurubu Planner Share Link Feature
This PR adds a link-sharing functionality to Gurubu Planner. Users can now share their planner configuration via URL, allowing others to bypass the initial team selection process and directly access the same planner view. Additionally, I've created a new PlannerContext to improve state management throughout the application.
Key Features
Technical Implementation
Related Issues
Closes #354