This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Suggest an image if entered word length is greater than 2 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrYoda
suggested changes
Feb 4, 2020
… Http retry is implemented. Prevent image suggestion after selection of any.
selcukusta
commented
Feb 5, 2020
selcukusta
commented
Feb 5, 2020
| @@ -157,9 +171,17 @@ func completer(d prompt.Document) []prompt.Suggest { | |||
| } | |||
|
|
|||
| if command == "pull" { | |||
| if strings.Index(word, ":") != -1 || strings.Index(word, "@") != -1 { | |||
There was a problem hiding this comment.
I've found a bug and tried to solve that. If the user entered a tag or digest, the search was running.
|
Merged, thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've re-enabled it suggestions of most pulled images from Hub API.
The suggester will be fired if the entered keyword length is greater than 2.
I've removed
if len(completer.([]prompt.Suggest)) > 0statement (line 127). If the entered keyword is01013fdand there's no image with this, the shell will be caching it to prevent send the invalid requests again.A little refactoring.
Screenshot