-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio): fix height limit and block flow improvements #640
Conversation
I fixed the styling issues about vertical alignment. I added a new CSS variable to be able to set vertical alignment of the radio button. By default, I set it as vertically centered. @buseselvi Please check if those are good for you. |
👀 👀 |
Do we have any concerns about this PR @stovein ? Can we merge this? |
We have a slight radio group alignment problem, since our radio groups host is now in flow layout but options classed div is in flex layout, we cannot directly manipulate alignment from host via giving classes or styles. We could add some measures for that and I think it will be ok and configurable most of the time. We could manage to solve this issue with @muratcorlu 's |
How is new sotry, if its ok I believe having a story would be better to get a feel how it works. |
It looks perfect 🙏🏻 But now the other example is not working when clicking on that radio input in the storybook, i couldn't select them. @stovein |
🎉 This PR is included in version 2.2.0-beta.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
since problem in the link provided is not related to this pr, we will continue from #659 . |
Fixes #597