Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): fix height limit and block flow improvements #640

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

stovein
Copy link
Contributor

@stovein stovein commented Jun 19, 2023

Fixes #597

@muratcorlu muratcorlu requested a review from buseselvi June 29, 2023 12:08
@muratcorlu muratcorlu marked this pull request as ready for review June 29, 2023 12:08
@muratcorlu
Copy link
Contributor

I fixed the styling issues about vertical alignment. I added a new CSS variable to be able to set vertical alignment of the radio button. By default, I set it as vertically centered. @buseselvi Please check if those are good for you.

@omrumbakitemiz
Copy link
Member

👀 👀

@muratcorlu
Copy link
Contributor

Do we have any concerns about this PR @stovein ? Can we merge this?

@stovein
Copy link
Contributor Author

stovein commented Jul 14, 2023

We have a slight radio group alignment problem, since our radio groups host is now in flow layout but options classed div is in flex layout, we cannot directly manipulate alignment from host via giving classes or styles. We could add some measures for that and I think it will be ok and configurable most of the time.

We could manage to solve this issue with @muratcorlu 's align-self on radio element suggestion, however I think we should also have some alignment css custom properties for radio group too.

An example of misalignment
image

@buseselvi
Copy link
Contributor

Title and radio inputs are looking a bit separated as an example. Can we show an example with 2-3 lines of text aligned middle and side by side, which looks more aesthetically pleasing? Or maybe just the explanation without an example in the storybook 🤔

image

@stovein
Copy link
Contributor Author

stovein commented Jul 14, 2023

How is new sotry, if its ok I believe having a story would be better to get a feel how it works.

@buseselvi
Copy link
Contributor

buseselvi commented Jul 14, 2023

It looks perfect 🙏🏻 But now the other example is not working when clicking on that radio input in the storybook, i couldn't select them. @stovein

@muratcorlu muratcorlu merged commit 039af1e into next Jul 14, 2023
@muratcorlu muratcorlu deleted the 597-radio-styling branch July 14, 2023 13:17
@muratcorlu muratcorlu mentioned this pull request Jul 14, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.2.0-beta.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stovein
Copy link
Contributor Author

stovein commented Jul 14, 2023

since problem in the link provided is not related to this pr, we will continue from #659 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio group and radio styling issues
5 participants