Skip to content

ehancing checks around auth headers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

ehancing checks around auth headers #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/Masking/FieldMasker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,15 @@ public function mask(array $data): array
string: $value,
);

$parts[1] = $this->star(
string: $parts[1],
);
if (count($parts) >= 2) {
for ($i = 1; $i < count($parts); $i++) {
$parts[$i] = $this->star(
string: $parts[$i]
);
}
} else {
$parts[0] = $this->star($parts[0]);
}

$value = implode(' ', $parts);
} else {
Expand Down
113 changes: 113 additions & 0 deletions tests/Masking/FieldMaskerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,116 @@
'foo' => 'bar',
]);
});

it('can handle a single Authorization entry', function () {
$masker = new FieldMasker(
fields: ['password', 'api_key', 'cc'],
);

expect($masker->mask(
data: [
'form' => [
'password' => 'password',
'api_key' => 'test',
],
'Authorization' => '123123123123123',
'X-API-KEY' => '1234-1234-4321',
'cc' => '1234-1234-1234-1234',
'foo' => 'bar',
],
))->toBeArray()->toEqual([
'form' => [
'password' => '********',
'api_key' => '****',
],
'Authorization' => '***************',
'X-API-KEY' => '**************',
'cc' => '*******************',
'foo' => 'bar',
]);
});

it('can handle a two Authorization entries', function () {
$masker = new FieldMasker(
fields: ['password', 'api_key', 'cc'],
);

expect($masker->mask(
data: [
'form' => [
'password' => 'password',
'api_key' => 'test',
],
'Authorization' => 'Bearer 123123123123123',
'X-API-KEY' => '1234-1234-4321',
'cc' => '1234-1234-1234-1234',
'foo' => 'bar',
],
))->toBeArray()->toEqual([
'form' => [
'password' => '********',
'api_key' => '****',
],
'Authorization' => 'Bearer ***************',
'X-API-KEY' => '**************',
'cc' => '*******************',
'foo' => 'bar',
]);
});


it('can handle a multiple Authorization entries', function () {
$masker = new FieldMasker(
fields: ['password', 'api_key', 'cc'],
);

expect($masker->mask(
data: [
'form' => [
'password' => 'password',
'api_key' => 'test',
],
'Authorization' => 'Bearer 123123123123123 123',
'X-API-KEY' => '1234-1234-4321',
'cc' => '1234-1234-1234-1234',
'foo' => 'bar',
],
))->toBeArray()->toEqual([
'form' => [
'password' => '********',
'api_key' => '****',
],
'Authorization' => 'Bearer *************** ***',
'X-API-KEY' => '**************',
'cc' => '*******************',
'foo' => 'bar',
]);
});

it('can handle a malformed Authorization entry', function () {
$masker = new FieldMasker(
fields: ['password', 'api_key', 'cc'],
);

expect($masker->mask(
data: [
'form' => [
'password' => 'password',
'api_key' => 'test',
],
'Authorization' => 'Alien',
'X-API-KEY' => '1234-1234-4321',
'cc' => '1234-1234-1234-1234',
'foo' => 'bar',
],
))->toBeArray()->toEqual([
'form' => [
'password' => '********',
'api_key' => '****',
],
'Authorization' => '*****',
'X-API-KEY' => '**************',
'cc' => '*******************',
'foo' => 'bar',
]);
});