cargo: Sync up MSRV with CI by setting rust-version
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the `+nightly -Zminimal-versions generate-lockfile` step to no longer generate a `version = 4` `Cargo.lock` which is incompatible with our 1.74 MSRV. And it communicates to crates.io and newer `cargo` versions with MSRV-aware resolver what our crate is going to be compatible with. Also drop the `macos-12` runner CI: GitHub no longer hosts it, and we already have `macos-13` and `macos-latest` anyway.
maxded
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
+nightly -Zminimal-versions generate-lockfilestep to no longer generate aversion = 4Cargo.lockwhich is incompatible with our 1.74 MSRV.And it communicates to crates.io and newer
cargoversions with MSRV-aware resolver what our crate is going to be compatible with.Also drop the
macos-12runner CI: GitHub no longer hosts it, and we already havemacos-13andmacos-latestanyway.