Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDX/AV: log message overhead when in faster modes #546

Open
jteresco opened this issue Jun 8, 2023 · 2 comments
Open

HDX/AV: log message overhead when in faster modes #546

jteresco opened this issue Jun 8, 2023 · 2 comments

Comments

@jteresco
Copy link
Contributor

jteresco commented Jun 8, 2023

It looks like oneAction is saving log messages and building the hover HTML for past logs every time, even when log messages are not being displayed.

Questions:

  • Can we skip all of those when running at speeds when the logging is not displayed?
  • Is there enough benefit to displaying the logs by default even at slower speeds?
  • Is there enough benefit to displaying the logs at all in terms of space in the AVCP?
@MikePlekan
Copy link
Collaborator

Edited log messages in order to only be created and displayed on slower speeds

jteresco added a commit that referenced this issue Jun 12, 2023
@jteresco
Copy link
Contributor Author

Remaining to do: set a boolean when speed changes to determine logging status, simplifying the conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants