avoid DISCONNECTED_ROUTE false negatives, etc. #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brevity, readability, efficiency
This unused datacheck will probably never hit production, but I like being able to uncomment it sometimes & see what I can see. This commit: * will keep this info accessible after 3 commits in the future, when datacheck.log will be written before graph gen is performed. * includes data from devel systems * improves straightforward_intersection CWN efficiency by short-circuiting & skipping an extraneous call to Waypoint::label_references_route
3600 cherrypicked 7b46 route_integrity comments f748 locations -> adjacent 3c45 coloc list for unique location ID 3ee2 add_to_adjacent function be6f comment cleanup; inline + add'l comment cleanup
cherrypick 7b46f45 manually recreate deltas for conflicts
no graph gen, yes CSV checks (plus path cleanup for Datacheck static functions)
rebase 49288bc itself a rebase of c627aec
|
Any reason I shouldn't merge this and go live for production? |
|
Nope. Ready to rock! |
Fun fact!This pull request includes siteupdate's first C++ lambda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9f95b0d is what it says on the tin.
5fb976b closes #610. Siteupdate avoids DISCONNECTED_ROUTE false negatives while going to greater lengths to make sure routes are connected to the best of its ability.
4cad17d is what it says on the tin.
Earlier commits were part of #615.
TLDR:
I wanted to get this working before doing any work on railway datachecks.
Plus fixed some errorchecks that weren't done in errorcheck mode before. Oops.
Closes #433
Closes yakra#242