Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrency detection / graphs #451

Merged
merged 10 commits into from
Aug 2, 2021
Merged

Conversation

yakra
Copy link
Contributor

@yakra yakra commented Jul 19, 2021

closes #450
closes yakra#177
closes #449
closes #248

unknown and others added 3 commits July 19, 2021 15:41
* speedup; find all concurrencies on 1st pass; ignore segments on subsequent passes
* prevent memory leak from overwritten/orphaned concurrency lists
* "reverse" check in HGEdge ctor no longer needed

interactive rebase d54bfbd89ced77e04655b9ac5a971b01551c59a5
unknown and others added 7 commits July 19, 2021 18:53
Datacheck: delete fp before invalidating iterator
main: prevent improper line.back() on empty nmpfps
TravelerList: don't "strip whitespace" before file BOF
ElapsedTime: plug memory leak on internal str buffer

cherrypick 827a225
comments on processing lines
delete unmatchedfps
Plug memory leaks in subgraph region/system lists


cherrypick d5810b8
delete[] updates & systemupdates
avoid invalid reads in read_wpt
while coping files that are empty or begin with  null zero
TravelMapping#248 (comment)
@yakra
Copy link
Contributor Author

yakra commented Jul 21, 2021

Added 7 more commits that help make siteupdate more "Valgrind clean", avoid invalid reads & writes, and plug lower-impact memory leaks.

Class destruction for bigger-ticket items is still subject to change, so I'm holding off on pushing to master for now.

@jteresco jteresco merged commit ea900be into TravelMapping:master Aug 2, 2021
@yakra
Copy link
Contributor Author

yakra commented Aug 3, 2021

Python speed on lab1

task before after
Concurrent segment detection 4.78 s 2.98 s
Creating edges 7.51 s 7.08 s

@yakra yakra deleted the genesis branch August 21, 2021 20:18
@yakra
Copy link
Contributor Author

yakra commented Oct 25, 2021

Deleting the genesis branch from BiggaTomato. In case I ever wanna refer back to it...
9ba652b92092e3f0042a8149203cdd5e21814806
Commits never pushed to GitHub include:

  • Commits squashed into the dreamcast branch for HGEdge memory management / speed #453
  • Experimental changes that didn't make the final cut, such as removing route_names_and_systems from siteupdate.py
  • The WIP on genesis stash was popped or deleted, and became 7874c4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants