devel systems in subgraph CSVs #614
Description
The HighwayGraph is composed of only data in active/preview systems.
Right now, if devel systems are listed in fullcustom.csv, multisystem.csv or systemgraphs.csv, siteupdate doesn't do anything special to detect them.
What happens?
I just made cannss-system-simple.tmg to find out. Haven't tried the other CSVs, but I expect the same behavior.
I got a perfectly valid file that loaded up fine in the HDX, with all the vertices & edges contained in the other, active, systems in Nova Scotia.
A bit counter to expectation -- one would either expect all of cannss be included (which we can't do because the graph structure is a/p only), or only the bits that are a/p in that system -- which is to say, nothing.
Easy fix.
When a valid system code is found in the CSV, check if it's active/preview before adding to the structure that tracks subgraph inclusion. Easy!
Right now, it's kind of no-harm-no-foul, but in the future, depending on how aggressive I want to get with conserving RAM, it may force our hand.
errorcheck?
Sure, these cases could be silently ignored. But so could unrecognized system codes, and there are errorchecks for those.
Having an errorcheck would let a contributor know that:
- the system code should be changed (e.g. typo, system got renamed, or something)
- or removed (both of these just the same as with unrecognized codes)
- or perhaps most importland... WHY DO I MAKE THAT TYPO ALL THE TIME importantly, the system should be promoted to preview in systems.csv.