Update dependencies for PHP 7 #15
Conversation
There was a problem hiding this comment.
Thank you @hotmeteor. I will get on this Tuesday or Wednesday if at all possible. Would you help me out by describing the issue you encountered with the current release of this library? My company uses it with PHP 7 today, so I'm unclear about the conditions under which the problem arises.
Dropping PHP 5.6 support is a breaking change that will require incrementing the major version number. So if there's no way to support both in the same library version, we'll have to call this 2.0.
|
@ethanpooley We're running Laravel 7.x (soon to be 8) and there's other libraries colliding with this one because it's using packages for later PHP 7 version (^7.2). Truthfully, this PR should probably be targeted at 7.3 and above, so ya, it's definitely a major version probably. |
|
I pulled this commit into a new branch, PRed as #16. Closing this one out. Thank you! |
|
Alright @hotmeteor, apologies for taking so long but v2 of this package is now available via Composer. Should do the job for you. |
|
👏 No worries, thanks! |
Modern apps (PHP 7+) require some of the dependencies to be updated in order to be interoperable.
This PR updates the necessary dependencies, and removes the support for PHP 5.