Bugfix XRPToDrops Conversion fixes #89#90
Open
JakeLardinois wants to merge 1 commit intoTransia-RnD:mainfrom
Open
Bugfix XRPToDrops Conversion fixes #89#90JakeLardinois wants to merge 1 commit intoTransia-RnD:mainfrom
JakeLardinois wants to merge 1 commit intoTransia-RnD:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional info:
NumberStyles.Float is a predefined combination of flags that already covers all the scenarios ie NumberStyles.Float ==
NumberStyles.AllowLeadingWhite |
NumberStyles.AllowTrailingWhite |
NumberStyles.AllowLeadingSign |
NumberStyles.AllowDecimalPoint |
NumberStyles.AllowExponent. Bitwise & between flags like AllowLeadingSign & AllowDecimalPoint results in 0 — they’re different bit positions, so you’re OR-ing together mostly ineffective combinations. In short: most of the manually combined styles collapse to AllowLeadingSign | AllowDecimalPoint | AllowExponent, which is exactly what Float already provides — but with more completeness (whitespace handling).
Removed duplicate "decimal.Parse(xrpToConvert..."
Removed if (!(xrpToConvert is string)...) because its always false
Used xrpValue directly in math
Added CultureInfo.InvariantCulture to final ToString() to prevent unexpected formatting