-
-
Notifications
You must be signed in to change notification settings - Fork 218
[WIP] Add unicodedata.normalize() #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add unicodedata.normalize() #548
Conversation
I'll whip up an autotest before this should be merged. Please let me know of any other things I should be aware of before this should be merged. |
Thanks for this speedy contribution! Currently Travis CI isn't up to par with Transcrypt. This will be a while, since the one who made the CI work currently isn't available, and I'm not exactly a Travis expert... But you can run the autotests off-line. To add an autotest for this module, add a testlet to ../Transcrypt/transcrypt/development/automated_tests/transcrypt. Also at an import and an autotester.run call to autotest.py. The principle of the autotest system is described at: http://www.transcrypt.org/docs/html/autotesting_transcrypt.html Due to the transition of TS 3.6 to TS 3.7 the documentation on autotesting may still lag back on some points. If so let me know so it can be updated. You should also be able to run the shipment test but it requires node.js' http-server to be installed (as the Python http server has some problems). |
As you have contributed a new file, it can't break anything, so I'll already merge this in the master branch. Note that 3.7 is still on the modules branch. So it's not yet in 3.7. Will be no big effort to merge it manually. Currently a minor reorganisation of the branching model is underway. |
I don't think there are other things you should be aware of. |
I've also manually drawn this into 3.7.4 |
Yes! I'll whip up a PR within the next two days. |
Thanks! And no hurry... |
Let me know if there's a way I can add automated tests for this module!
Here's a simple test for this function:
Addresses #547