updated Dockerfile #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrafeX
reviewed
Dec 29, 2021
Dockerfile
Outdated
|
|
||
| # Install packages and remove default server definition | ||
| RUN apk --no-cache add \ | ||
| RUN apk add --no-cache --update \ |
There was a problem hiding this comment.
Why are you adding the --update flag?
There was a problem hiding this comment.
Update repository indexes.
There was a problem hiding this comment.
I think this is not needed since --no-cache already ignores the local cache if there was any.
There was a problem hiding this comment.
You're right, i already removed it
|
Also, if you pull in the master branch the build should succeed. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congratulations for the repository, I made some small changes to reduce the size of the image, highlight the supervision in go-lang, I noticed other improvements but if I accepted this contribution I'll send it as much as possible.