Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PKCE instead of traditional oauth flow #115

Closed
wants to merge 4 commits into from
Closed

Conversation

DRSchlaubi
Copy link
Contributor

No description provided.

@DRSchlaubi DRSchlaubi marked this pull request as draft January 30, 2023 20:02
- Rename PCKEUtil.kt to PKCEUtil.kt
@DRSchlaubi DRSchlaubi marked this pull request as ready for review January 31, 2023 07:51
@jheubuch
Copy link
Collaborator

jheubuch commented Feb 7, 2023

Maybe we also can store the refresh token so that we can refresh the tokens before they expire.
Also we should wait to merge this, until scopes are ready and then implement the scopes we need.

@DRSchlaubi
Copy link
Contributor Author

Sounds reasonable, I will also base the push notifications PR on this as it requires modification of auth logic as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants