Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip and exit #777

Merged
merged 9 commits into from
Jun 21, 2023
Merged

fix: skip and exit #777

merged 9 commits into from
Jun 21, 2023

Conversation

simboonlong
Copy link
Contributor

@simboonlong simboonlong commented Jun 21, 2023

  • ensure npm run build:prod is ran and required by branch protection, regardless of [skip test]
  • skipping each step in Testcafe e2e Test, no straight forward way to manage conditionals in action, exit 0 needed for branch protection

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for tradetrust-mainnet ready!

Name Link
🔨 Latest commit bfeb1cc
🔍 Latest deploy log https://app.netlify.com/sites/tradetrust-mainnet/deploys/6492b4ae23885400073e798f
😎 Deploy Preview https://deploy-preview-777--tradetrust-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@simboonlong simboonlong marked this pull request as ready for review June 21, 2023 07:46
@simboonlong simboonlong requested a review from isaackps June 21, 2023 08:32
@simboonlong simboonlong merged commit 29edc3a into master Jun 21, 2023
@simboonlong simboonlong deleted the fix/skip-and-exit branch June 21, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants