Skip to content

Conversation

@MarkAtRamp51
Copy link
Contributor

Proposed changes
Two new handlebars tokens were added to allow for the use of {{comment}} on table templates and {{property-comment}} on property templates. This can be useful to incorporate database description metadata into XML doc comments on the models.

Related Issue
There isn't an associated issue at this time.

@MarkAtRamp51
Copy link
Contributor Author

@tonysneed thanks for your patience. Give this a try, and let me know what needs an update.

@tonysneed
Copy link
Contributor

tonysneed commented May 4, 2020

@MarkAtRamp51 All the changes look good. I approve the PR. Do you want to perform Steps 16-17 in the Contributing Guidelines to squash your commits? If you don't succeed, or do not wish to perform the squash, just don't push your changes. Just let me know and I can do the squash from my side.

@MarkAtRamp51
Copy link
Contributor Author

Yes I'll do it. Thank you.

@tonysneed tonysneed changed the title Feature/supporting schema comments Supporting for schema comments May 4, 2020
@tonysneed tonysneed added the enhancement New feature or request label May 4, 2020
@MarkAtRamp51 MarkAtRamp51 changed the title Supporting for schema comments Support for schema comments May 4, 2020
@MarkAtRamp51
Copy link
Contributor Author

@tonysneed I think it's good to go.

@tonysneed tonysneed merged commit 8608acb into TrackableEntities:master May 4, 2020
@tonysneed
Copy link
Contributor

@MarkAtRamp51 You did the squash! Congratulations!

@MarkAtRamp51
Copy link
Contributor Author

@tonysneed Haha, yeah it was much easier than trying to squash and merge all those other commits. It definitely felt like a happy path "squash." I'm looking to be more active in a project so If you think there is anything you could use help on let me know. Thanks again for your support.

@MarkAtRamp51 MarkAtRamp51 deleted the feature/supporting-schema-comments branch May 4, 2020 23:49
@tonysneed
Copy link
Contributor

You passed the squash test. :) amA bit more advanced is rebasing on top of upstream commits. We can try that next time. And I’ll be very grateful for your help on other feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants