-
Notifications
You must be signed in to change notification settings - Fork 54
Schema foldering support #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@JohnGoldInc As I described in #99, I don't think schema foldering has anything to do with transformers, and you should not have to use them in order to add the schema folders. Instead, I think a preferable approach would be to add an What do you think? |
|
I was thinking that way because they might want to play with class name too
and gives most utility to the dev ( without making changes to handlebars
scaffolding)
…On Tue, Apr 28, 2020 at 5:55 PM Anthony Sneed ***@***.***> wrote:
@JohnGoldInc <https://github.com/JohnGoldInc> As I described in #99
<#99>,
I don't think schema foldering has anything to do with transformers, and
you should not have to use them in order to add the schema folders.
Instead, I think a preferable approach would be to add an
EnableSchemaFolders property to ReverseEngineerOptions so that you can
set it to true in ConfigureDesignTimeServices when calling
services.AddHandlebarsScaffolding.
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFYVE4SXFH6KDQPCET2UMDRO5GDJANCNFSM4MS3GIEQ>
.
|
|
It won't be difficult to add transformers support via arguments for It would be great if you could create a new PR from scratch that takes the approach I suggested. To do this create a new branch from the latest commit on my master branch (5b2d3d2). Use this branch for your new PR. For some guidance on creating the PR, please refer to the Contributing Guidelines. |
|
@tonysneed Ok was looking at ReverseEngineerOptions it would have to change to be a binary pipe concatenated. So the original code: would become : And code changed to test via binary matching instead of equivalency throughout project. Sound Good? |
|
@tonysneed And regarding #99 "EnableNullableReferenceTypes = 8" because the numbering needs to be an exponent of 2 |
|
@JohnGoldInc Sorry, I meant public class HandlebarsScaffoldingOptions
{
public bool EnableSchemaFolders { get; set; }
public bool EnableNullableReferenceTypes { get; set; } // Not part of this issue/PRPlease discuss |
This provides for the ability to folder Entities by the schema of the tables,
And keeps class naming to the same standard of capability.
Closes #111