Skip to content

Conversation

@codingdna2
Copy link
Contributor

@codingdna2 codingdna2 commented Apr 23, 2020

In this PR I did the followings (see issue #107):

  • GenerateForeignKeyAttribute now generates attribute using nameof when possible
  • GenerateInversePropertyAttribute now generates attribute using nameof when possible
  • TableAttribute is correctly formatted in class.hbs (tab was missing)

@codingdna2 codingdna2 changed the title DataAnnotation: Usage of nameof in ForeignKeyAttribute/InversePropertyAttribute #107 DataAnnotation: Usage of nameof in ForeignKeyAttribute/InversePropertyAttribute Apr 23, 2020
@tonysneed tonysneed added the bug Something isn't working label Apr 25, 2020
@tonysneed
Copy link
Contributor

tonysneed commented Apr 28, 2020

@codingdna2 Would it be too much trouble to ask you to squash your two commits into just one? (If not, it’s OK.) See these instructions on interactive rebase.

After squashing run git push --force from the command line.

For guidance on creating PRs, please refer to the Contributing Guidelines.

@tonysneed tonysneed merged commit 2a755f6 into TrackableEntities:master Apr 29, 2020
@tonysneed
Copy link
Contributor

@codingdna2 I went ahead and merged this PR, so that you will be unblocked for #109. You'll have a chance to practice git squash on that PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataAnnotation: Usage of nameof in ForeignKeyAttribute/InversePropertyAttribute

2 participants