Update to emit transformed NavPropertyNames

[dmayhak]

No description provided.

[tonysneed]

After making these two changes, please squash your commits into one, then force push the commit to your branch.

After this I will merge your PR. Thanks!

[tonysneed]

Line 812 should be:

+ (foreignKey.IsUnique ? $"<{EntityTypeTransformationService.TransformPropertyName(((ITypeBase)foreignKey.PrincipalEntityType).DisplayName())}>" : "")

[tonysneed]

@dmayhak You still need to make this change, so that generic type arguments are transformed.

[tonysneed]

Line 818 should be:

+ (foreignKey.IsUnique ? $"<{EntityTypeTransformationService.TransformPropertyName(((ITypeBase)foreignKey.DeclaringEntityType).DisplayName())}>" : "")

[tonysneed]

@dmayhak You still need to make this change, so that generic type arguments are transformed.

[tonysneed]

@dmayhak Would you be able to make the requested changes?

[codingdna2]

I guess similar modifications are required in HbsCSharpEntityTypeGenerator.

[codingdna2]

I found an additional issue with the usage of TransformNavPropertyName and TransformPropertyName. See commit 3e16d8f and 15ce17f. It was quite hard to fix for me, so maybe a double check is needed

[codingdna2]

@tonysneed Please check the above. Thanks!

[tonysneed]

If you run the ScaffoldingSample, with Add optional Handlebars transformers uncommented, then you'll see this in OnModelCreating in NorthwindSlimContext:

entity.HasOne(d => d.CustomerFoo)
    .WithOne(p => p.CustomerSettingFoo)
    .HasForeignKey<CustomerSetting>(d => d.CustomerIdFoo)
    .OnDelete(DeleteBehavior.ClientSetNull)
    .HasConstraintName("FK_CustomerSetting_Customer");

Should be CustomerSettingFoo. This will be corrected if you make the changes I requested above.

Aside from this, everything else looks good, as far as I can tell.

[tonysneed]

Let me know when you have made these changes, then we can talk about how to prepare your PR for merging.

[codingdna2]

I think I did in this commit 4906c14

[codingdna2]

I’ll run the tests you suggested tomorrow! Thanks for your support!

[tonysneed]

@codingdna2 I don't see your recent commits (4906c14, 3e16d8f) on this PR branch, which is 'master' in fork by @dmayhak. Can you point me to the branch where you pushed you recent commits?

Perhaps you could create a separate PR for your branch? Please see the Contributing Guidelines.

[tonysneed]

Covered by #118.