Property names with special characters (ä,ö,ü) are converted to unicode strings

[skriebi]

Hello,

some of the columns in our database contains special characters (ä,ö,ü).
The characters are converted to ä, ö or ü unicode strings.

To solve the issue for me, I have created a hbs-helper, which simple writes the property-name with the WriteSafeString-Method of the TextWriter.

Helper registration:

    public void ConfigureDesignTimeServices(IServiceCollection services)
    {
        var options = ReverseEngineerOptions.DbContextAndEntities;
        services.AddHandlebarsScaffolding(options);
        
        Handlebars.RegisterHelper("f-pn", FormatPropertyName);
    }

    void FormatPropertyName(TextWriter writer, object context, object[] args)
    {
        writer.WriteSafeString(args[0].ToString());
    }

Usage in templates:
{{f-pn property-name}}

I think, the property-name template should use the WriteSafeString-Method.

[tonysneed]

You should add your helper like so:

services.AddHandlebarsHelpers(myHelper);

See here.

I think, the property-name template should use the WriteSafeString-Method.

Perhaps you should open an issue on Handlebars.Net, since the templates should use WriteSafeString? I recommend that, because it would solve the problem of special characters globally.

[ErikEJ]

Reported here: ErikEJ/EFCorePowerTools#77

[ErikEJ]

EF Core team (and I) use UTF8 encoding...

[tonysneed]

@ErikEJ What do you think I should do to fix this?

[ErikEJ]

It looks like a Handlebars issue to me...
https://github.com/TrackableEntities/EntityFrameworkCore.Scaffolding.Handlebars/blob/master/src/EntityFrameworkCore.Scaffolding.Handlebars/Internal/FileSystemFileService.cs#L65

[tonysneed]

Confirmed this is a Handlebars.Net issue. There needs to be a way to suppress HTML encoding. See Issue 276 there.

[tonysneed]

Closing, as this needs to be fixed by Handlebars.NET.

[tonysneed]

Re-opening, as this issue was fixed in v2 of Handlebars.Net.