Add safeURL to social icons links #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track3
requested changes
Oct 27, 2019
There was a problem hiding this comment.
This is useful, just one minor suggestion, it's better using {{.url | safeURL}} instead of {{safeURL .url}} here, just because this pipe like format is used in almost anywhere across the theme. Both is correct and works, just to improve code consistency please change this and I'll merge, thanks!
The social icon links are generated from developer-controlled config.toml file. They can be considered safe. This enables using various URI schemes such as `tel:`, `sip:`, `geo:` or `whatever:`.
nicolas-guichard
force-pushed
the
patch-1
branch
from
ec9c4e4 to
c6af673
Compare
|
OK, done! I'm quite new to Hugo and didn't know both syntax were correct. |
Track3
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The social icon links are generated from developer-controlled
config.tomlfile. They can be considered safe.This enables using various URI schemes such as
tel:,sip:,geo:orwhatever:.