Conversation
varkey98
commented
Nov 13, 2025
Contributor
Author
There was a problem hiding this comment.
removing long deprecated configs from the proto. None of them are used in our agents (except for the remote config from inside blocking configs, but this has been deprecated for longer than my career here, so hopefully we can remove it)
tim-mwangi
reviewed
Nov 13, 2025
|
|
||
| FilterPipelineManager pipeline_manager = 21; | ||
|
|
||
| // Config to run detection on agent side without blocking |
Contributor
Author
There was a problem hiding this comment.
Yes, if we turn this on we still run the rules, but wont block
Contributor
There was a problem hiding this comment.
What's the advantage of doing it here instead of the platform?
Contributor
Author
There was a problem hiding this comment.
I think its because we can run the detection before they get sampled out.
tim-mwangi
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.