ENGTAI-67042: adding identifying attributes config#44
Conversation
thugrock7
requested review from
prodion23,
shashank11p,
tim-mwangi and
varkey98
varkey98
left a comment
varkey98
left a comment
There was a problem hiding this comment.
Pls link a ticket to the pr title
| // Agent identification attributes config | ||
| message AgentIdentity { | ||
| // path of the agent ID file | ||
| google.protobuf.StringValue id_file = 1; |
There was a problem hiding this comment.
What's gonna be inside the identity file?
There was a problem hiding this comment.
the ID of agent, for the cases to preserve same ID for agent even on restarts we use this
There was a problem hiding this comment.
Is the ID itself automatically generated or does this need to be set by the customer?
There was a problem hiding this comment.
For this I think the idea is that we make our bootstrap logic (deb or rpm scripts for VMs & helm or tf for k8s) populate. Not sure what we can do for docker though. Although if its used by external services ECS, we can again make the ecs template put this value in so that it doesnt change for a deployment.
There was a problem hiding this comment.
Is the ID itself automatically generated or does this need to be set by the customer?
ID itself should be automatically generated. This config just exposes file path of optional configuring where to store that ID file. The responsibility of generating that ID still lies with agent (like in goagent).
For this I think the idea is that we make our bootstrap logic (deb or rpm scripts for VMs & helm or tf for k8s) populate. Not sure what we can do for docker though. Although if its used by external services ECS, we can again make the ecs template put this value in so that it doesnt change for a deployment.
Yup, we will be populating this value in our bootstrap logic for VM/k8's(helm/tf) deployments with a default value and will not involve customer unless they want to place this file on some different location.
+1 |
| // path of the agent ID file | ||
| google.protobuf.StringValue id_file = 1; | ||
| // deployment_name is used as a part of Agent Identifying attributes to group the agents | ||
| google.protobuf.StringValue deployment_name = 2; |
There was a problem hiding this comment.
Is this optional or can it be inferred from config the customer already sets? eg cluster-name. It's good to have it configurable but would love to avoid customers adding even more config especially for telemetry.
There was a problem hiding this comment.
+1. I always thought this would be just internal use. In that case, maybe we can wire this in as options pattern instead of adding it as a config
There was a problem hiding this comment.
Is this optional or can it be inferred from config the customer already sets?
This is optional and will be provided by customer if they want to group/identify the specific agent. One of the use case is like, say if customer have multiple TPA deployments in different regions, and say they want to update config / perform some debug initiatives on TPA/TPA's of one region, then configuring this field would come into play.
I always thought this would be just internal use.
Nope, this is set by the customer.
Discussion over this can be found in 1st page https://docs.google.com/document/d/1IdgmQJDA0bAL9uqjc6w3cILHGDRMaqs1k77HnQBVTzQ/edit?tab=t.0
thugrock7
changed the title
3 participants
No description provided.