Refactor ExistanceStore

[allada]

Refactor Existance Store to be compatible with store API.

---

This change is 

[allada]

+@blakehatch

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @blakehatch)

[blakehatch]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @allada)

---

native-link-store/src/existence_store.rs line 88 at r1 (raw file):

        self.pin_inner()
            .has_with_results(&not_cached_digests, &mut inner_results)
            .await?;

Nit: .err_tip(|| "In ExistenceStore::inner_has_with_results")

---

native-link-util/src/evicting_map.rs line 33 at r1 (raw file):

#[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
pub struct SerializedLRU {
    pub data: Vec<(DigestInfo, i32)>,

Nit: Is there a way to use evicting_map for it's pruning capabilities without having to store any data as existence is just being checked? Probably an over-optimization especially since this approach limits the size of the data stored and by extension the upside of an optimization like this but something to consider.

[allada]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @allada)

---

native-link-util/src/evicting_map.rs line 33 at r1 (raw file):

Previously, blakehatch (Blake Hatch) wrote…

Nit: Is there a way to use evicting_map for it's pruning capabilities without having to store any data as existence is just being checked? Probably an over-optimization especially since this approach limits the size of the data stored and by extension the upside of an optimization like this but something to consider.

Storing a () (ie: void) costs 1 byte (in C, so probably the same in rust), so the overhead is so small it is negligible.

Long answer: Yes, but it would be a pain to refactor and use.

[allada]

Reviewable status: 9 of 10 files reviewed, all discussions resolved (waiting on @blakehatch)

---

native-link-store/src/existence_store.rs line 88 at r1 (raw file):

Previously, blakehatch (Blake Hatch) wrote…

Nit: .err_tip(|| "In ExistenceStore::inner_has_with_results")

Done.

[blakehatch]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @allada)