Repository navigation
Generate PreconditionFailure - #2333
Merged
Merged
Conversation
palfrey
commented
May 14, 2026
| name = "doc_test", | ||
| timeout = "short", | ||
| crate = ":nativelink-proto", | ||
| ) |
Member
Author
There was a problem hiding this comment.
For some annoying reason, the new proto makes some things that look like doc tests, but fail. Given all the code is generic generated code, it shouldn't really have any doc tests anyways.
palfrey
force-pushed
the
precondition-generate
branch
2 times, most recently
from
May 14, 2026 14:47
9a06d0a to
68aa158
Compare
palfrey
force-pushed
the
precondition-generate
branch
from
May 14, 2026 15:30
68aa158 to
7dab4e9
Compare
palfrey
marked this pull request as ready for review
May 14, 2026 15:54
MarcusSorealheis
approved these changes
May 14, 2026
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
Member
There was a problem hiding this comment.
We should have done this but iteration is most important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nativelink-util/src/precondition_failure.rshad a hardcoded copy ofPreconditionFailurewhen we've done all the other gRPC messages via generation from.protofiles. This PR redoes it with that mechanism, and then uses the existingTypeUrltrait to be able to put theTYPE_URLconstant in a slightly more organised location.Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
bazel test //...Checklist
bazel test //...passes locallygit amendsee some docsThis change is