Repository navigation
Split rbe-toolchain into multiple tests - #2330
Merged
Merged
Conversation
palfrey
force-pushed
the
split-rbe-toolchain
branch
from
May 13, 2026 16:28
a13e8aa to
28e45ee
Compare
palfrey
force-pushed
the
split-rbe-toolchain
branch
from
May 13, 2026 16:40
28e45ee to
cad7331
Compare
palfrey
force-pushed
the
split-rbe-toolchain
branch
from
May 13, 2026 16:51
62e8532 to
b3b84ef
Compare
palfrey
commented
May 13, 2026
| *llvm* | ||
| mysql* | ||
| dotnet-sdk-* | ||
| remove_packages_one_command: true |
Member
Author
There was a problem hiding this comment.
This is incredibly slow, sometimes minutes, and doesn't save us that much vs the raw removing of folders.
palfrey
marked this pull request as ready for review
May 14, 2026 09:28
amankrx
approved these changes
May 14, 2026
rejuvenile
pushed a commit
to rejuvenile/nativelink
that referenced
this pull request
Aug 19, 2026
* Split rbe-toolchain into multiple tests * Disable slow remove packages step
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's the slowest test by about a factor of 2-3x now, mostly because it's got a lot of subtests. This PR gives the command a
listsubcommand as well as the ability to run individual subcommands. The overall end-to-end time for a RBE test goes from ~24m to ~6m max, even though there's a lot more of them. This does increase our needed test runner count a bunch, but only on Ubuntu machines which we have a lot of headroom for and tend to get allocated very fast.It also removes the "remove package" step of the free disk action, as that wasn't freeing up much space, but it was very unreliable in terms of runtime, and especially with more separate jobs it was radically increasing the runtime sometimes.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
CI
Checklist
bazel test //...passes locallygit amendsee some docsThis change is