Repository navigation
Add ability for metris to be disabled - #215
Conversation
allada
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @chrisstaite-menlo)
d3b1258 to
86bcb42
Compare
|
I wonder, should metrics always be disabled when there's no service and enabled when there's at least one? |
|
I think if there's no server specified then metrics should be disabled too. |
chrisstaite-menlo
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @allada)
Adds the ability to disable metrics through env via TURBO_CACHE_DISABLE_METRICS or through config file.
86bcb42 to
6cc2b6d
Compare
allada
left a comment
There was a problem hiding this comment.
Done.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @chrisstaite-menlo)
cas/cas_main.rs line 432 at r1 (raw file):
Previously, chrisstaite-menlo (Chris Staite) wrote…
I think if there's no server specified then metrics should be disabled too.
Done.
chrisstaite-menlo
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
Two doc-only edits in `api_worker_scheduler.rs` addressing reviewer findings on the TraceMachina#214 BIS replay buffer cap: * `bis_replay_buffer_overflow_drops` doc comment claimed the counter is "the operator-visible signal." Reality: `SchedulerMetrics` lacks `#[derive(MetricsComponent)]` so the counter is internal-only. Operator visibility today is the per-(endpoint, broadcast_id) `warn!` log; the counter is reachable via tests / debug only. Filed TraceMachina#231 to wire the metrics exporter. * `BIS_REPLAY_BUFFER_MAX_CHUNKS` doc cited "16 GiB per worker" based on wire-encoded chunk size. Decoded heap representation is closer to ~38 GiB at the cap (96 B/Digest × 4096 × 100K plus prost framing). With 80 GiB MemoryMax, single-misbehaving-worker defense holds; two simultaneous misbehavers get tight. Comment now points to TraceMachina#215 + TraceMachina#216 for full defense-in-depth. Pure documentation; no behavior change. HEAD `b9befaf1` is unchanged in semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds the ability to disable metrics through env via TURBO_CACHE_DISABLE_METRICS or through config file.
This change is