Skip to content

Initial implementation of remote persistent workers #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Initial implementation of remote persistent workers #1922

wants to merge 29 commits into from

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Sep 3, 2025 •
edited
Loading

Description

Remote persistent workers are coming to Nativelink! Not there yet.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@MarcusSorealheis MarcusSorealheis marked this pull request as draft September 3, 2025 23:41
@MarcusSorealheis MarcusSorealheis force-pushed the remote-persistent-workers branch from 42c8b8e to c69655d Compare September 4, 2025 01:12
palfrey
palfrey reviewed Oct 3, 2025
View reviewed changes
integration_tests/persistent-workers-test/package.json
"build": "tsc",
"lint": "eslint src/**/*.ts",
"test": "jest",
"test:integration": "npm run build && node dist/integration.test.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist. Maybe was meant to be e2e.test.ts? But replacing with that doesn't work either. ts-node src/e2e.test.ts possibly, after installing ts-node but that doesn't seem to fully work.

palfrey
palfrey reviewed Oct 3, 2025
View reviewed changes
integration_tests/persistent-workers-test/README.md

```bash
npm run build
node dist/e2e.test.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist in dist after running build.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ready. I need to work on this more. Sorry for confusion

@MarcusSorealheis MarcusSorealheis marked this pull request as draft October 3, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palfrey palfrey palfrey requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcusSorealheis @palfrey @amankrx