Skip to content

Conversation

ddemaree
Copy link

@ddemaree ddemaree commented Apr 29, 2025

Updates the Astro.site configuration value to docs.nativelink.com, the new home domain for the documentation site now that the main site at https://nativelink.com has relaunched.


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haw was this tested? Do we have a demo deployment somewhere?

Reviewable status: 0 of 2 LGTMs obtained, and 0 of 1 files reviewed

@ddemaree
Copy link
Author

@aaronmondal I'm working with Meghan, Phil, and co. on the new nativelink.com site and also getting the docs migrated to a new subdomain. This Astro config change was tested locally, but I haven't pushed it live anywhere yet, and haven't run the full test suite because the scope of the change is so small. Happy to connect in the Trace team Slack if it'll help!

Copy link
Contributor

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just migrate the HTML/CSS code into the existing website in this repo? Where does the code for that new website live? Happy to sync on this offline.

Reviewable status: 0 of 2 LGTMs obtained, and 0 of 1 files reviewed

@ddemaree
Copy link
Author

ddemaree commented Apr 29, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants