-
Notifications
You must be signed in to change notification settings - Fork 199
Change Astro.site config for new URL #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haw was this tested? Do we have a demo deployment somewhere?
Reviewable status: 0 of 2 LGTMs obtained, and 0 of 1 files reviewed
@aaronmondal I'm working with Meghan, Phil, and co. on the new nativelink.com site and also getting the docs migrated to a new subdomain. This Astro config change was tested locally, but I haven't pushed it live anywhere yet, and haven't run the full test suite because the scope of the change is so small. Happy to connect in the Trace team Slack if it'll help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just migrate the HTML/CSS code into the existing website in this repo? Where does the code for that new website live? Happy to sync on this offline.
Reviewable status: 0 of 2 LGTMs obtained, and 0 of 1 files reviewed
It's based on Webflow and hosted on their cloud, so no. I'll follow up in Slack. Thanks!
Sent via Superhuman iOS ( ***@***.*** )
…On Tue, Apr 29, 2025 at 6:12 PM, Aaron Siddhartha Mondal < ***@***.*** > wrote:
***@***.**** commented on this pull request.
Can you just migrate the HTML/CSS code into the existing website in this
repo? Where does the code for that new website live? Happy to sync on this
offline.
>
>
> Reviewable (
> https://reviewable.io/reviews/TraceMachina/nativelink/1729#-:-OP2aBix7Ar-A3G198BU:b7d12up
> ) status: 0 of 2 LGTMs obtained, and 0 of 1 files reviewed
>
>
—
Reply to this email directly, view it on GitHub (
#1729 (review)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAAHRIEZBBQ665FKGD3VM32372NTAVCNFSM6AAAAAB4DGKDGGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMBVGE4TGOJZGI
).
You are receiving this because you authored the thread. Message ID: <TraceMachina/nativelink/pull/1729/review/2805193992
@ github. com>
|
Updates the
Astro.site
configuration value todocs.nativelink.com
, the new home domain for the documentation site now that the main site at https://nativelink.com has relaunched.This change is