Fix clippy::needless_pass_by_value #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
force-pushed
the
fix/clippy-needless_pass_by_value
branch
from
2540c96
to
4be3dac
Compare
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
SchahinRohani
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Reviewed 12 of 15 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
bazel test ...Checklist
bazel test //...passes locallygit amendsee some docsThis change is