-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy::semicolon_if_nothing_returned #1393
Fix clippy::semicolon_if_nothing_returned #1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
nativelink-worker/src/running_actions_manager.rs
line 1199 at r1 (raw file):
OutputType::DirectorySymlink(output_symlink) => { output_directory_symlinks.push(output_symlink); }
nit
Suggestion:
OutputType::FileSymlink(output_symlink) =>
output_file_symlinks.push(output_symlink),
OutputType::DirectorySymlink(output_symlink) =>
output_directory_symlinks.push(output_symlink),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
nativelink-worker/src/running_actions_manager.rs
line 1199 at r1 (raw file):
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
nit
cargo fmt
formats it like this:
OutputType::DirectorySymlink(output_symlink) => {
output_directory_symlinks.push(output_symlink);
}
So i guess the current formatting follows the standard Rust conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 LGTMs obtained, and all files reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: complete! 2 of 1 LGTMs obtained, and all files reviewed
How Has This Been Tested?
bazel test ...
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is