Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy::semicolon_if_nothing_returned #1393

Conversation

SchahinRohani
Copy link
Contributor

@SchahinRohani SchahinRohani commented Oct 4, 2024

How Has This Been Tested?

bazel test ...

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved


nativelink-worker/src/running_actions_manager.rs line 1199 at r1 (raw file):

                    OutputType::DirectorySymlink(output_symlink) => {
                        output_directory_symlinks.push(output_symlink);
                    }

nit

Suggestion:

                    OutputType::FileSymlink(output_symlink) =>
                        output_file_symlinks.push(output_symlink),
                    OutputType::DirectorySymlink(output_symlink) =>
                        output_directory_symlinks.push(output_symlink),

Copy link
Contributor Author

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved


nativelink-worker/src/running_actions_manager.rs line 1199 at r1 (raw file):

Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…

nit

cargo fmt formats it like this:

OutputType::DirectorySymlink(output_symlink) => {
    output_directory_symlinks.push(output_symlink);
}

So i guess the current formatting follows the standard Rust conventions.

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained, and all files reviewed

@aaronmondal aaronmondal merged commit 553f33c into TraceMachina:main Oct 7, 2024
31 checks passed
@SchahinRohani SchahinRohani deleted the fix/clippy-semicolon_if_nothing_returned branch October 7, 2024 02:30
Copy link
Member

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained, and all files reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants