Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs.nativelink.com based URL not working #1386

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix docs.nativelink.com based URL not working #1386

merged 1 commit into from
Oct 10, 2024

Conversation

aleksdmladenovic
Copy link
Contributor

@aleksdmladenovic aleksdmladenovic commented Oct 3, 2024 •
edited by allada
Loading

Description

URLs starting docs.nativelink.com is redirected to introduction URL always. Found all occurrences of docs.nativelink.com and replaced that with nativelink.com/docs.

More details can be found in the link below.

Fixes #1385

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@aleksdmladenovic
Fix docs.nativelink.com based URL not working
7051909 
URLs starting `docs.nativelink.com` is redirected to introduction URL
always. Found all occurrences of `docs.nativelink.com` and replaced that
with `nativelink.com/docs`.
@aleksdmladenovic
Copy link
Contributor Author

Waiting review on this.

cc: @allada, @MarcusSorealheis, @blakehatch, @SchahinRohani

SchahinRohani
SchahinRohani approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Good work you fixed those links!

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable

aaronmondal
aaronmondal approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 2 LGTMs obtained, and all files reviewed

@aaronmondal aaronmondal merged commit d602746 into TraceMachina:main Oct 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchahinRohani SchahinRohani SchahinRohani approved these changes

@aaronmondal aaronmondal aaronmondal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix docs.nativelink.com based URL not working
3 participants
@aleksdmladenovic @SchahinRohani @aaronmondal