Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy::redundant_closure_for_method_calls #1380

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix clippy::redundant_closure_for_method_calls #1380

merged 1 commit into from
Sep 30, 2024

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Sep 30, 2024 •
edited by allada
Loading

This change is Reviewable

SchahinRohani
SchahinRohani approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Installation / macos-13, Installation / macos-14

@aaronmondal aaronmondal force-pushed the clippy-redundant_closure_for_method_calls branch from ebccbc7 to 77697c6 Compare September 30, 2024 21:37
SchahinRohani
SchahinRohani approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, docker-compose-compiles-nativelink (22.04), macos-13, windows-2022 / stable

@aaronmondal aaronmondal merged commit 2b24ce2 into TraceMachina:main Sep 30, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchahinRohani SchahinRohani SchahinRohani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronmondal @SchahinRohani