Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Redis Scheduler #1343

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

allada
Copy link
Member

@allada allada commented Sep 10, 2024

Adds an experimental redis scheduler that can be used as a distributed state-persistent scheduler backend. This scheduler is optimized to have each worker be its own scheduler or many small schedulers.

closes: #359


This change is Reviewable

@allada allada changed the title New Redis scheduler [Feature] Add Redis Scheduler Sep 10, 2024
Copy link
Member Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@adam-singer

Reviewable status: 0 of 1 LGTMs obtained, and 0 of 18 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Docs Deployment / macos-14, Docs Deployment / ubuntu-24.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache (Legacy Dockerfile Test), Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @adam-singer)

Adds an experimental redis scheduler that can be used as a distributed
state-persistent scheduler backend. This scheduler is optimized to have
each worker be its own scheduler or many small schedulers.

closes: TraceMachina#359
Copy link
Member

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained, and all files reviewed

@allada allada merged commit a6c3a6f into TraceMachina:main Sep 11, 2024
30 checks passed
@allada allada deleted the new-redis-scheduler branch September 11, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Support shared database API for schedulers
2 participants