Move trivial data access Mutex's to sync Mutex.

[chrisstaite-menlo]

The Tokio documentation suggests that using an async Mutex for trivial data access (where the data is not required over an await) is more expensive and therefore should be avoided. This is due to the fact that the operations performed while the Mutex is locked are trivial and therefore switching task on the tokio thread is far more inefficient than simply waiting for the Mutex to become available.

See: https://docs.rs/tokio/latest/tokio/sync/struct.Mutex.html and https://tokio.rs/tokio/tutorial/shared-state

---

This change is 

[allada]

Reviewed 13 of 14 files at r1, all commit messages.
Reviewable status: 13 of 14 files reviewed, 2 unresolved discussions (waiting on @chrisstaite-menlo)

---

cas/worker/running_actions_manager.rs line 952 at r1 (raw file):

    }

    fn get_action(&self, action_id: &ActionId) -> Result<Arc<Self::RunningAction>, Error> {

nit: I was following some code paths and found this entire function is never called.

Can we clean it up here?

---

cas/worker/running_actions_manager.rs line 966 at r1 (raw file):

            running_actions
                .iter()
                .filter_map(|(_action_id, action)| action.upgrade())

fyi: This could have been done without creating a Vec using:

.for_each(Self::kill_action)

---

cas/worker/running_actions_manager.rs line 970 at r1 (raw file):

        };
        for action in kill_actions {
            Self::kill_action(action)

nit: Lets keep this an await for now because #129 (comment) Needs to be fixed.

[allada]

Reviewable status: 13 of 14 files reviewed, 2 unresolved discussions (waiting on @chrisstaite-menlo)

[chrisstaite-menlo]

Reviewable status: 13 of 14 files reviewed, all discussions resolved (waiting on @allada)

---

cas/worker/running_actions_manager.rs line 966 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

fyi: This could have been done without creating a Vec using:

.for_each(Self::kill_action)

The Vec is required to drop the lock. I tried inlining it with the for_each and it looked ugly...

[allada]

Reviewed 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @chrisstaite-menlo)