[Change] BEP Redis key format (#1345)

":" is the preferred way since Redis Insight from Redis itself shows your keys inside directories with ":".
TraceMachina · Sep 12, 2024 · ba5b315 · ba5b315
1 parent a6c3a6f
commit ba5b315
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/nativelink-service/src/bep_server.rs b/nativelink-service/src/bep_server.rs
@@ -75,7 +75,7 @@ impl BepServer {
         self.store
             .update_oneshot(
                 StoreKey::Str(Cow::Owned(format!(
-                    "LifecycleEvent-{}-{}-{}",
+                    "LifecycleEvent:{}:{}:{}",
                     &stream_id.build_id, &stream_id.invocation_id, sequence_number,
                 ))),
                 buf.freeze(),
@@ -114,7 +114,7 @@ impl BepServer {
             store
                 .update_oneshot(
                     StoreKey::Str(Cow::Owned(format!(
-                        "BuildToolEventStream-{}-{}-{}",
+                        "BuildToolEventStream:{}:{}:{}",
                         &stream_id.build_id, &stream_id.invocation_id, sequence_number,
                     ))),
                     buf.freeze(),

diff --git a/nativelink-service/tests/bep_server_test.rs b/nativelink-service/tests/bep_server_test.rs
@@ -117,7 +117,7 @@ async fn publish_lifecycle_event_test() -> Result<(), Box<dyn std::error::Error>
     let sequence_number = request.clone().build_event.unwrap().sequence_number;
 
     let store_key = StoreKey::Str(Cow::Owned(format!(
-        "LifecycleEvent-{}-{}-{}",
+        "LifecycleEvent:{}:{}:{}",
         stream_id.clone().build_id,
         stream_id.clone().invocation_id,
         sequence_number
@@ -280,7 +280,7 @@ async fn publish_build_tool_event_stream_test() -> Result<(), Box<dyn std::error
                 .iter()
                 .map(|request| {
                     StoreKey::Str(Cow::Owned(format!(
-                        "BuildToolEventStream-{}-{}-{}",
+                        "BuildToolEventStream:{}:{}:{}",
                         stream_id.build_id,
                         stream_id.invocation_id,
                         request