Fix clippy::inconsistent_struct_constructor (#1412)

.bazelrc

@@ -45,7 +45,7 @@ build --aspects=@rules_rust//rust:defs.bzl%rustfmt_aspect
 build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
 
 # TODO(aaronmondal): Extend these flags until we can run with clippy::pedantic.
-build --@rules_rust//:clippy_flags=-Dwarnings,-Dclippy::uninlined_format_args,-Dclippy::manual_string_new,-Dclippy::manual_let_else,-Dclippy::single_match_else,-Dclippy::redundant_closure_for_method_calls,-Dclippy::semicolon_if_nothing_returned,-Dclippy::unreadable_literal,-Dclippy::range_plus_one
+build --@rules_rust//:clippy_flags=-Dwarnings,-Dclippy::uninlined_format_args,-Dclippy::manual_string_new,-Dclippy::manual_let_else,-Dclippy::single_match_else,-Dclippy::redundant_closure_for_method_calls,-Dclippy::semicolon_if_nothing_returned,-Dclippy::unreadable_literal,-Dclippy::range_plus_one,-Dclippy::inconsistent_struct_constructor
 build --@rules_rust//:clippy.toml=//:clippy.toml
 
 test --@rules_rust//:rustfmt.toml=//:.rustfmt.toml

nativelink-service/src/bytestream_server.rs

@@ -255,9 +255,9 @@ impl ByteStreamServer {
         });
         Ok(ActiveStreamGuard {
             stream_state: Some(StreamState {
+                uuid,
                 tx,
                 store_update_fut,
-                uuid,
             }),
             bytes_received,
             bytestream_server: self,

nativelink-service/src/worker_api_server.rs

@@ -13,10 +13,10 @@
 // limitations under the License.
 
 use std::collections::HashMap;
+use std::convert::Into;
 use std::pin::Pin;
 use std::sync::Arc;
 use std::time::{Duration, SystemTime, UNIX_EPOCH};
-use std::convert::Into;
 
 use futures::stream::unfold;
 use futures::Stream;

nativelink-util/src/action_messages.rs

@@ -1140,8 +1140,8 @@ impl ActionState {
             .err_tip(|| "Could not convert action_digest into DigestInfo")?;
 
         Ok(Self {
-            client_operation_id,
             stage,
+            client_operation_id,
             action_digest,
         })
     }

nativelink-util/src/common.rs

@@ -80,8 +80,8 @@ impl DigestInfo {
             ));
         }
         Ok(DigestInfo {
-            size_bytes,
             packed_hash,
+            size_bytes,
         })
     }
 
@@ -285,8 +285,8 @@ impl TryFrom<Digest> for DigestInfo {
             .try_into()
             .map_err(|_| make_input_err!("Could not convert {} into u64", digest.size_bytes))?;
         Ok(DigestInfo {
-            size_bytes,
             packed_hash,
+            size_bytes,
         })
     }
 }
@@ -302,8 +302,8 @@ impl TryFrom<&Digest> for DigestInfo {
             .try_into()
             .map_err(|_| make_input_err!("Could not convert {} into u64", digest.size_bytes))?;
         Ok(DigestInfo {
-            size_bytes,
             packed_hash,
+            size_bytes,
         })
     }
 }

nativelink-util/src/connection_manager.rs

@@ -300,8 +300,8 @@ impl ConnectionManagerWorker {
                 |err| Err((identifier, err)),
                 |channel| {
                     Ok(EstablishedChannel {
-                        identifier,
                         channel,
+                        identifier,
                     })
                 },
             )