Add NationRangeAllowTownEvent#8128
Conversation
Allowing other plugins to override Towny's proximity rules
|
In regards to my 2nd commit, if you think firing an event for each town when just gathering a list of in range towns is unnecessary, it can be moved to ProximityUtil#removeOutOfRangeTowns as that's the only usage that kicks them. Other usages are just a warning to players when moving nation/town, or when merging a nation. |
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
Generally looks fine to me, the the event could use some javadocs explaining what it does, how it can be fired pre-cancelled if the town isn't allowed according to nation range rules
LlmDl
left a comment
LlmDl
left a comment
There was a problem hiding this comment.
This looks alright but it looks like a town that is within range of the nation never gets an event thrown which would stop a plugin from making things more strict than Towny would act.
It might be worth making it throw an event for every town that is tested.
|
Done |
3 participants
Description:
Added NationRangeAllowTownEvent, allowing other plugins to override/ignore Towny's proximity rules
For my specific case, I'd like to allow towns from the other side of the world border to join nations
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.