feat: #80: investigation and correction of hash mismatches during the signing process by aasheptunov · Pull Request #86 · TourmalineCore/c2pie

aasheptunov · 2026-05-27T04:16:27Z

No description provided.

…s size of serialized app11 segments

…flow

…o separate method

…pdated

… to the Data Hash Assertion constructor

… Data Hash Assertion

…so that make it more readability

…ifference exceeds the length of the pad

…ches-during-the-signing-process' of https://github.com/TourmalineCore/c2pie into feature/#80-investigation-and-correction-of-hash-mismatches-during-the-signing-process

…ameter in the Data Hash Assertion

…BOR boundary is violated

…propriate file; comment them out

…ches-during-the-signing-process' of https://github.com/TourmalineCore/c2pie into feature/#80-investigation-and-correction-of-hash-mismatches-during-the-signing-process

…H was determined

…a separate method;

…ches-during-the-signing-process' of https://github.com/TourmalineCore/c2pie into feature/#80-investigation-and-correction-of-hash-mismatches-during-the-signing-process

…fference is no more than 3 bytes

…rtion

JDRkow · 2026-06-01T10:09:23Z

please delete commented code and tests if its not usable anymore

…df object

…ata Hash Assertion and unprotected header

…ed header

…ectly

aasheptunov · 2026-06-02T03:26:16Z

please delete commented code and tests if its not usable anymore

If you're referring to additional_exclusions, this code works, but without the logic to account for exclusions when calculating the hash, it results in an invalid signature. I've commented out the relevant parameter to prevent unexpected errors, and the tests have been adjusted correspondingly.

Once the logic for handling exclusions is implemented, the commented-out code can be restored.

…nd related tests

aasheptunov and others added 30 commits May 25, 2026 09:12

test: #80: refactor e2e test to make it cleaner

94262bd

test: #80: add a test to verify that specified exclusion value matche…

fb379a5

…s size of serialized app11 segments

refactor: #80: refactor c2pa storage data hash exclusion calculation …

99d5d15

…flow

test: #80: modify exclusion cover test so that it covers pdf case

904cd63

refactor: #80: refactor c2pa storage data hash exclusion calculation …

03ca728

…flow

chore: #80: rename pdf test file so that filename more readability

c751c4a

refactor: #80: move logic for adding exclusions to C2PA structure int…

bb26494

…o separate method

test: #80: add test to align serialized COSE_Sign1

e0cfcc7

feat: #80: add alignment logic for serialized COSE_Sign1

f7ad081

test: #80: update to Data Hash Assertion test, as pad size has been u…

836a96c

…pdated

test: #80: update exclusion coverage test to reflect the changes made…

00a5a80

… to the Data Hash Assertion constructor

docs(readme): bring test coverage score up to date

a08dccc

feat: #80: add handling for CBOR boundary violation cases for TSA tokens

1323202

refactor: #80: rework logic for handling CBOR boundary violations for…

31025d9

… Data Hash Assertion

chore: #80: rename serialized_length to serialized_cose_sign1_length …

c62e2cb

…so that make it more readability

fix: #80: correct of a typo in the condition

0ef4d7b

test: #80: add a test that checks for a ValueError exception if the d…

ab941f2

…ifference exceeds the length of the pad

Merge branch 'feature/#80-investigation-and-correction-of-hash-mismat…

556284c

…ches-during-the-signing-process' of https://github.com/TourmalineCore/c2pie into feature/#80-investigation-and-correction-of-hash-mismatches-during-the-signing-process

docs(readme): bring test coverage score up to date

0edc648

docs: #80: add a clarifying comment for the additional_exclusions par…

e9a364d

…ameter in the Data Hash Assertion

test: #80: add a test to verify the CBOR tag in COSE_Sign1_Tagged

b3f25df

fix: #80: fix for an error related to the pad not changing when the C…

3c342ae

…BOR boundary is violated

test: #80: move the test for checking additional_exclusions to the ap…

ef985d7

…propriate file; comment them out

Merge branch 'feature/#80-investigation-and-correction-of-hash-mismat…

98b4d22

…ches-during-the-signing-process' of https://github.com/TourmalineCore/c2pie into feature/#80-investigation-and-correction-of-hash-mismatches-during-the-signing-process

docs(readme): bring test coverage score up to date

36ec059

docs: #80: add a comment explaining how JPG_SEGMENT_MAX_PAYLOAD_LENGT…

0b0d678

…H was determined

refactor: #80: move logic for emplacing the APP11 storage bytes into …

6cdb5ac

…a separate method;

Merge branch 'feature/#80-investigation-and-correction-of-hash-mismat…

1c9f86a

…ches-during-the-signing-process' of https://github.com/TourmalineCore/c2pie into feature/#80-investigation-and-correction-of-hash-mismatches-during-the-signing-process

docs(readme): bring test coverage score up to date

c949792

refactor: #80: minimize pad size for unprotected header, since the di…

849f3a6

…fference is no more than 3 bytes

test: #80: change hash in the test schema override for Data Hash Asse…

743808f

…rtion

JDRkow reviewed Jun 1, 2026

View reviewed changes

Comment thread c2pie/c2pa/assertion.py Outdated

Comment thread c2pie/c2pa/assertion.py

Comment thread c2pie/c2pa_injection/pdf_injection.py Outdated

Comment thread c2pie/c2pa/assertion.py Outdated

aasheptunov and others added 7 commits June 1, 2026 15:16

fix: #80: fix for error caused by incorrect length specified in the p…

363151e

…df object

docs: #80: add clarifying comments for value stored in pad field in D…

5538e42

…ata Hash Assertion and unprotected header

test: #80: update test after changing value of pad field in unprotect…

fb6cbe1

…ed header

chore: #80: fix a typo

c5c0a10

docs: #80: add number of issue to todo comment for additional_exclusions

f6f130f

test: #80: add test for check that pad calcutation was performed corr…

ef646b4

…ectly

docs(readme): bring test coverage score up to date

3a3a0b6