test(ui): fixes default values not set TCTC-4635 #1602
Conversation
vue-class-component is not really active anymore it has a problem with setting the default prop value
|
Your Render PR Server URL is https://weaverbird-playground-pr-1602.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cdp3g3qen0hivi1oo8h0. |
| }, | ||
|
|
||
| availableVariables: { | ||
| type: Array as PropType<VariablesBucket>, |
There was a problem hiding this comment.
those are required or default to undefined? In which case `as PropType< VariablesBucket | undefined>
Same for above
There was a problem hiding this comment.
Sure about this? Seems like the TS figures that out itself. Example:
There was a problem hiding this comment.
ah ok cool! It has been improved then! It used to be a problem
| @@ -97,91 +96,161 @@ type OperatorOption = { | |||
|
|
|||
| export const DEFAULT_FILTER = { column: '', value: '', operator: 'eq' }; | |||
|
|
|||
| @Component({ | |||
| const nullOperators: Readonly<OperatorOption[]> = [ | |||
There was a problem hiding this comment.
👍
Can probably be in a registry util
There was a problem hiding this comment.
What do you mean by a registry util?
In a dedicated file with constants (outside the component file)?
(If yes, I agree!)
There was a problem hiding this comment.
OK! If it's OK, I prefer to do this later on, to first unblock Tucana's testswith the new version of weaverbird
Same problem of default value
Doesn't solve our pbs though
It's already run by yarn format: ci, so we can speed up eslint
davinov
changed the title
| @@ -412,7 +412,7 @@ describe.skip('Widget FilterSimpleCondition', () => { | |||
| it('should not pass the variables props if hideColumnVariables is true', () => { | |||
| const customProps = { | |||
| availableVariables: ['test'], | |||
| variableDelimiters: ['test'], | |||
| variableDelimiters: {start:'te', end: 'st'}, | |||
| @@ -255,7 +259,7 @@ export default defineComponent({ | |||
| created() { | |||
| // In absence of condition, emit directly to the parent the default value | |||
| if (isEqual(this.value, DEFAULT_FILTER)) { | |||
| this.$emit('input', DEFAULT_FILTER); | |||
| this.$emit('input', { ...DEFAULT_FILTER }); | |||
There was a problem hiding this comment.
Une raison de pas faire this.value plutôt? Ca éviterait de faire deux spread operator et la value est déjà isolée non 🤔 ?
There was a problem hiding this comment.
Tu as raison, mieux vaut ne pas changer l'existant - ce n'est pas le but de cette PR. Je remet!
For an unknown reason, the default value of a prop seemed never applied.
We found some issues about this in vue-class-component's repo, but non e of the solutions worked.
So I switched to
defineComponent, which works like a charm.