fix(server/pandas/filter): Fix datetime object comparisons TCTC-4268 #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://weaverbird-playground-pr-1524.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cd1uq41gp3jqar61rclg. |
lukapeschke
force-pushed
the
fix-filter-dates-pandas
branch
from
2386b52
to
c20dd15
Compare
Sanix-Darker
approved these changes
Oct 10, 2022
Comment on lines
+29
to
+31
| else: # str | ||
| ts = Timestamp(value) | ||
| return ts if ts.tzinfo else ts.replace(tz="UTC") |
There was a problem hiding this comment.
Suggested change
| else: # str | |
| ts = Timestamp(value) | |
| return ts if ts.tzinfo else ts.replace(tz="UTC") | |
| # str | |
| ts = Timestamp(value) | |
| return ts if ts.tzinfo else ts.replace(tz="UTC") |
There was a problem hiding this comment.
Linters prefer this, but our style in the various repos is to have an else branch even when returning in previous branches
lukapeschke
force-pushed
the
fix-filter-dates-pandas
branch
from
c20dd15
to
66ab444
Compare
relates to TCTC-4268 Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
force-pushed
the
fix-filter-dates-pandas
branch
from
66ab444
to
7f3821c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Peschke luka.peschke@toucantoco.com