fix(server/pypika/filter): Fix "notmatches" operator for backends using REGEXP #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://weaverbird-playground-pr-1507.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cctg4rsgqg485qt0tgr0. |
…ng REGEXP closes TCTC-3808 Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
force-pushed
the
fix-pattern-snowflake
branch
from
67509f5
to
1432095
Compare
Sanix-Darker
approved these changes
Oct 4, 2022
| @@ -177,7 +177,7 @@ def test_notmatches_regexp_filter( | |||
| ctx = regexp_translator.filter(step=step, columns=selected_columns, **default_step_kwargs) | |||
| expected_query = ( | |||
| Query.from_(previous_step) | |||
| .where(Field(column).regexp(regex).negate()) | |||
| .where(Field(column).regexp(f"%{regex}%").negate()) | |||
There was a problem hiding this comment.
Something like what has been done here : https://github.com/ToucanToco/weaverbird/pull/1508/files#diff-8837be4fbba25365c35a1d19668a79c588fac28c89e62882642b0dc93b5557fdL159-R163 sound better IMO
There was a problem hiding this comment.
I disagree. Here, I want to test that the function is called with the regex surrounded by % characters. The test form you suggest would not catch an error if the get_compliant_regex function was bogus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TCTC-3808
Signed-off-by: Luka Peschke luka.peschke@toucantoco.com