Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server/pypika/gbq): Fix split step quoting TCTC-3806 #1506

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

lukapeschke
Copy link
Contributor

The separator should be escaped as a string literal (single quotes).

relates to TCTC-3806

Signed-off-by: Luka Peschke luka.peschke@toucantoco.com

@lukapeschke lukapeschke added need review pypika Changes concern the PyPika translator labels Oct 3, 2022
@lukapeschke lukapeschke self-assigned this Oct 3, 2022
@render
Copy link

render bot commented Oct 3, 2022

The separator should be escaped as a string literal (single quotes).

relates to TCTC-3806

Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
…other backends

Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke merged commit 0906b44 into master Oct 4, 2022
@lukapeschke lukapeschke deleted the fix-split-step branch October 4, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review pypika Changes concern the PyPika translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants