[PROD-2020] Improve OH tests #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To ensure the quality and working state of the OffsetHelper while also making tests more understandable and easier to work on when needed.
How?
Note: The diff may seem big (or at least it does to me), but most of it is very similar refactorings that just repeat multiple times.
I first did a few small refactorings like:
.test.ts
extension.not.be.reverted
(why is it problematic? see the issue description here)parseEther("1.0")
s into a constantThen I went on to bigger work:
Improving
autoOffset
,autoRedeem
andautoRetire
related testsI grouped each of these, as relevant to their tested method, in their own commit because they were quite similar. I took each test (where it made sense) and I:
expect
so when tests fail you know where it failedFollow-up
I feel like the current improvements already take this a long way, but there are other things that I want to do. The problem is that this is already a lengthy PR and I don't want to make it even harder to review.
Some of the things I want to do in a follow-up PR:
deposit()
,withdraw()
and particularlyswap()
testsshould retire using a WMATIC swap and NCT redemption
test tobeforeAll
scope