Send comments as robotComments (#238)#239
Open
marquiswang wants to merge 1 commit intoTouK:masterfrom
Open
Conversation
SpOOnman
suggested changes
Jun 24, 2021
src/main/java/pl/touk/sputnik/connector/gerrit/ReviewInputBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/touk/sputnik/connector/gerrit/ReviewInputBuilder.java
Outdated
Show resolved
Hide resolved
marquiswang
force-pushed
the
robotComment
branch
from
ec75313 to
a12aec1
Compare
Robot comments show up in the Findings tab, instead of in the comments. This makes it much easier to differentiate from them a reviewer's comments. The API requires a "runId" for the comment. I've chosen to just send a random UUID for now, but eventually we could wire in something like a build number or something.
marquiswang
force-pushed
the
robotComment
branch
from
a12aec1 to
99902df
Compare
Contributor
Author
|
@SpOOnman extremely belatedly, here's another version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robot comments show up in the Findings tab, instead of in the comments.
This makes it much easier to differentiate from them a reviewer's
comments.
The API requires a "runId" for the comment. I've chosen to just send a
random UUID for now, but eventually we could wire in something like a
build number or something.