Skip to content

Conversation

@Julian332
Copy link

@Julian332 Julian332 commented Nov 24, 2025

Motivation

fix for issue : #627

Solution

because connect fn is stucked, so it executed after on_disconnect ,this insert a entry(sid , eio(closed) ) to namespace , so remove this entry if found eio is closed

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #628 will not alter performance

Comparing Julian332:fix_async_connect_timeout (8949983) with main (59d98af)

Summary

✅ 87 untouched

@Totodore
Copy link
Owner

Hey, thanks for your PR, could you also add a regression test please?

I'll try to do review this week

@Julian332
Copy link
Author

Hey, thanks for your PR, could you also add a regression test please?

I'll try to do review this week

thanks for your replay, but which kind of regression test , I found some test about this fn's behaviour, they all are passed .
image

@Totodore
Copy link
Owner

By regression test I mean a test that fails without your fix and passes thanks to your fix.

@Julian332
Copy link
Author

By regression test I mean a test that fails without your fix and passes thanks to your fix.

hello,I have add that test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants