Repository navigation
Move remote request handling into core behind the remote-adapter feature flag #774
Description
Part of #727.
Move the duplicated remote-request handling from the redis, postgres and mongodb
adapters into socketioxide_core behind the existing remote-adapter feature flag.
Current state: each adapter implements a near-identical recv_req dispatch plus the
same recv_* handlers (~110 LOC per adapter): broadcast, broadcast_with_ack,
disconnect_sockets, all_rooms, add/del sockets, fetch sockets. Each also repeats the
same get_res / broadcast_with_ack skeleton (response channel setup,
ResponseHandlers insert, ResponseTypeId filter, take(remote_serv_cnt), request
timeout).
Proposed shared API (sketch, in core):
- A
RemoteRequestHandlertrait (naming TBD) implemented by each adapter, exposing
only what the handlers need: the localCoreLocalAdapter, the adapteruid, a
send_ressink, and the heartbeat hook from refactor(core): move heartbeat/liveness logic into core behind remote-adapter feature #768. - Default
recv_reqdispatch and allrecv_*implementations provided on the trait. - A shared response-wait helper covering the
get_res/broadcast_with_ackskeleton.
Each adapter then keeps only its wire-specific parts (codec, driver calls,
channel/item routing). No behavior or wire-format change.
Activity
LiamCarPer commentedon Aug 23, 2026
Hey, here is what i was thinking for this PR:
A shared trait in core (
RemoteRequestHandler<E>behindremote-adapter) with default implementations of therecv_reqdispatch plus all 7recv_*handlers (~150 LOC once instead of 3 times). Each adapter only implementslocal()(theCoreLocalAdapter, which covers everything the handlers use, including uid/ns/ack_timeout for the logs),send_resand an overridablerecv_heartbeathook (no-op by default, postgres and mongodb delegate to theHeartbeatSenderlogic from #768). Redis keeps a tiny decode-and-delegate wrapper, postgres and mongodb just delete their copies.A small response-wait helper covering the identical
get_restail (channel sizing +ResponseHandlersinsert +ResponseTypeIdfilter +take(serv_cnt)+ timeout) and wrapping uniformly inDropStream. Btw this also fixes a leak: postgres is the only adapter whoseget_resdoesn't wrap inDropStream, so its rooms/fetch handler entries pile up in the map forever. Happy to split that fix into its own commit if you prefer.Some normalizations (tiny differences, picked on purpose):
send_resunified to(req_id, req_origin)arg order plus the strictest bounds (T: Serialize + Debug + Send + 'static, future+ Send + 'static), redis's inverted order is handled inside its imploptson a request: warn and skip everywhere (redis already does, postgres and mongodb silently drop it right now)Deferred to the codec PR: sharing the outbound
broadcast_with_ackbody, it needs associated types for the raw response item + decoder which belong with the codec work.One thing i noticed while i was in there, not touched by this PR: redis's
broadcast_with_ackpassesopts.server_idas the send target but always usesserver_count - 1as the expected ack count, so a targeted broadcast's ack stream completes by timeout instead of cleanly. Flagging it in case you want a separate issue for it.Totodore commentedon Aug 29, 2026
Seems good to me, please make a separate PR redis bug fix.