Skip to content

fix(vm): retain legacy JPEG bridge ABI - #504

Open
flsobral wants to merge 1 commit into
masterfrom
codex/pr502-legacy-jpeg-followup
Open

flsobral wants to merge 1 commit into
masterfrom
codex/pr502-legacy-jpeg-followup

Conversation

@flsobral

@flsobral flsobral commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Keep the historical tuiI_createJpgNative_si entry as an explicit compatibility bridge.
  • Forward the old entry to the current tuiI_createJpgImpl_si implementation.
  • Add regressions for the legacy registration and generated header/table output.

Why

The pre-cutover shadow comparison showed that old SDK bytecode called Image.createJpgNative(Stream, int), but the generated core table only contained the renamed createJpgImpl symbol. Preserving the old entry keeps SDK TCZs built before the rename compatible.

Validation

  • Focused bridge tests passed.
  • validateDeployedJavaApi passed.
  • check passed: 608 tests, 0 failures/errors, 23 skipped.
  • dist -x test passed.
  • Two strict shadow generations produced identical hashes. The final comparison retains all legacy registrations; the only generated additions are tdsNDB_result_error_ls and tuiI_createJpgImpl_si.
  • Local macOS arm64 Release Ninja build linked tcvm and Launcher; nm confirmed all three affected bridge symbols are defined and registered.
  • GitHub Actions run 38277550856 passed: SDK, bridge generation, Linux amd64/arm32v7/arm64, Windows, Windows legacy, macOS arm64, Android, and iOS. The disabled linux-arm32v7-cross job was skipped.
  • No native builds outside macOS were run locally.

@flsobral
flsobral marked this pull request as ready for review October 12, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant